Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identical lines not squeezed #186

Open
TheLocehiliosan opened this issue Jan 17, 2023 · 3 comments · May be fixed by #213
Open

Identical lines not squeezed #186

TheLocehiliosan opened this issue Jan 17, 2023 · 3 comments · May be fixed by #213
Labels
documentation enhancement New feature or request

Comments

@TheLocehiliosan
Copy link

The help indicates:

--no-squeezing Displays all input data. Otherwise any number of groups of output lines which would be identical to the preceding group of lines, are replaced with a line comprised of a single asterisk.

It seems that lines are squeezed when they all are filled with the same single byte (for example, all 0x00 or all 0xFF). However, lines which are not filled with a single repeated byte can still be identical to previous lines. In these cases they do not appear to be squeezed.

I'll attach an example file, which contains rows filled with the two-byte word 0x1400 starting at position 00000020. If the standard two panels are displayed, I would expect this file to have data squeezed until position 00000fa0.

example.tar.gz
@sharkdp
Copy link
Owner

sharkdp commented Jan 17, 2023

Thank you for reporting this. The documentation is just wrong. I don't think the squeezing feature was ever planned to work that way. But I now realize that hexdumps squeezing feature might actually do just that?

FYI: @awidegreen @sharifhsn

@TheLocehiliosan
Copy link
Author

But I now realize that hexdumps squeezing feature might actually do just that?

Yes, hexdump does work that way.

@sharifhsn
Copy link
Contributor

If hexdump will squeeze on identical lines always, then the squeezing feature should be changed to match hexdump. It's not difficult to make this change, I'll look at this sometime soon.

@sharkdp sharkdp added the enhancement New feature or request label Apr 21, 2023
@sharifhsn sharifhsn linked a pull request Dec 12, 2023 that will close this issue
Open
Taraxtix added a commit to Taraxtix/hexyl that referenced this issue Mar 3, 2024
@Taraxtix
Fixes the Squeezing bug where identical lines that are not a single r…
711230f 
…epeating byte were not squeezed (see sharkdp#186)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Squeeze identical lines sharifhsn/hexyl
3 participants
@TheLocehiliosan @sharkdp @sharifhsn