Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitignore workaround #1521

Merged
merged 3 commits into from Apr 30, 2024
Merged

Gitignore workaround #1521

merged 3 commits into from Apr 30, 2024

Conversation

tmccombs
Copy link
Collaborator

@tmccombs tmccombs commented Mar 14, 2024

Workaround for bug with gitinored files

This is a workaround for
BurntSushi/ripgrep#2711

Fixes: #1461

Copy link
Collaborator

@tavianator tavianator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this workaround is incomplete: we should do the same thing if the user passes . as a path explicitly.

It's also worth adding a test case I think.

And make sure it works for user-supplied path of "."

Also add changelog entry
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Owner

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sharkdp sharkdp merged commit 9279b1f into sharkdp:master Apr 30, 2024
16 checks passed
@tmccombs tmccombs deleted the gitignore-workaround branch April 30, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Including hidden files also includes (git)ignored files if the .gitignore is in the parent directory
3 participants