[BUG] Build fails with --target armv7-unknown-linux-gnueabi

[hgy59]

Checks

• I have read the troubleshooting section and still think this is a bug.

Describe the bug you encountered:

Until fd 8.7.0 build with --target armv7-unknown-linux-gnueabi works fine.

For fd 8.7.1 there is a linker error

error: linking with `/spksrc/toolchain/syno-hi3535-6.2.4/work/arm-cortexa9-linux-gnueabi/bin/arm-cortexa9-linux-gnueabi-gcc` failed: exit status: 1
  |
  = note: LC_ALL="C" PATH="/spksrc/distrib/rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/bin:/spksrc/distrib/cargo/bin:/spksrc/cross/fd/../../distrib/cargo/bin:/spksrc/cross/fd/../../distrib/cargo/bin:/spksrc/toolchain/syno-x86-6.2.4/../../distrib/cargo/bin:/scripts:/usr/local/bin:/usr/bin:/bin:/usr/games" VSLANG="1033" "/spksrc/toolchain/syno-hi3535-6.2.4/work/arm-cortexa9-linux-gnueabi/bin/arm-cortexa9-linux-gnueabi-gcc" "/tmp/rustcbOW9bB/symbols.o" "/spksrc/cross/fd/work-hi3535-6.2.4/fd-8.7.1/target/armv7-unknown-linux-gnueabi/release/deps/fd-f2cff162ee66e01d.fd.e477d554b120399b-cgu.0.rcgu.o" "-Wl,--as-needed" "-L" "/spksrc/cross/fd/work-hi3535-6.2.4/fd-8.7.1/target/armv7-unknown-linux-gnueabi/release/deps" "-L" "/spksrc/cross/fd/work-hi3535-6.2.4/fd-8.7.1/target/release/deps" "-L" "/spksrc/cross/fd/work-hi3535-6.2.4/fd-8.7.1/target/armv7-unknown-linux-gnueabi/release/build/jemalloc-sys-a9978fef0ba428ab/out/build/lib" "-L" "/spksrc/distrib/rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/armv7-unknown-linux-gnueabi/lib" "-Wl,-Bstatic" "/tmp/rustcbOW9bB/libjemalloc_sys-7d1a32bd7f6af56f.rlib" "/spksrc/distrib/rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/armv7-unknown-linux-gnueabi/lib/libcompiler_builtins-c7422c3976ceb70a.rlib" "-Wl,-Bdynamic" "-lgcc_s" "-lutil" "-lrt" "-lpthread" "-lm" "-ldl" "-lc" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-L" "/spksrc/distrib/rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/armv7-unknown-linux-gnueabi/lib" "-o" "/spksrc/cross/fd/work-hi3535-6.2.4/fd-8.7.1/target/armv7-unknown-linux-gnueabi/release/deps/fd-f2cff162ee66e01d" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-Wl,-O1" "-Wl,--strip-all" "-nodefaultlibs"
  = note: /spksrc/toolchain/syno-hi3535-6.2.4/work/arm-cortexa9-linux-gnueabi/bin/../lib/gcc/arm-cortexa9-linux-gnueabi/4.8.3/../../../../arm-cortexa9-linux-gnueabi/bin/ld.bfd: BFD (crosstool-NG 1.20.0) 2.24 assertion fail /home/cpt/hi3535/.build/src/binutils-2.24/bfd/elf32-arm.c:12387
          /spksrc/toolchain/syno-hi3535-6.2.4/work/arm-cortexa9-linux-gnueabi/bin/../lib/gcc/arm-cortexa9-linux-gnueabi/4.8.3/../../../../arm-cortexa9-linux-gnueabi/bin/ld.bfd: BFD (crosstool-NG 1.20.0) 2.24 assertion fail /home/cpt/hi3535/.build/src/binutils-2.24/bfd/elf32-arm.c:12387
          /spksrc/toolchain/syno-hi3535-6.2.4/work/arm-cortexa9-linux-gnueabi/bin/../lib/gcc/arm-cortexa9-linux-gnueabi/4.8.3/../../../../arm-cortexa9-linux-gnueabi/bin/ld.bfd: BFD (crosstool-NG 1.20.0) 2.24 assertion fail /home/cpt/hi3535/.build/src/binutils-2.24/bfd/elf32-arm.c:12387
          /spksrc/toolchain/syno-hi3535-6.2.4/work/arm-cortexa9-linux-gnueabi/bin/../lib/gcc/arm-cortexa9-linux-gnueabi/4.8.3/../../../../arm-cortexa9-linux-gnueabi/bin/ld.bfd: BFD (crosstool-NG 1.20.0) 2.24 assertion fail /home/cpt/hi3535/.build/src/binutils-2.24/bfd/elf32-arm.c:12387
          /spksrc/toolchain/syno-hi3535-6.2.4/work/arm-cortexa9-linux-gnueabi/bin/../lib/gcc/arm-cortexa9-linux-gnueabi/4.8.3/../../../../arm-cortexa9-linux-gnueabi/bin/ld.bfd: BFD (crosstool-NG 1.20.0) 2.24 assertion fail /home/cpt/hi3535/.build/src/binutils-2.24/bfd/elf32-arm.c:12387
          /spksrc/toolchain/syno-hi3535-6.2.4/work/arm-cortexa9-linux-gnueabi/bin/../lib/gcc/arm-cortexa9-linux-gnueabi/4.8.3/../../../../arm-cortexa9-linux-gnueabi/bin/ld.bfd: BFD (crosstool-NG 1.20.0) 2.24 assertion fail /home/cpt/hi3535/.build/src/binutils-2.24/bfd/elf32-arm.c:12387
          /spksrc/toolchain/syno-hi3535-6.2.4/work/arm-cortexa9-linux-gnueabi/bin/../lib/gcc/arm-cortexa9-linux-gnueabi/4.8.3/../../../../arm-cortexa9-linux-gnueabi/bin/ld.bfd: BFD (crosstool-NG 1.20.0) 2.24 assertion fail /home/cpt/hi3535/.build/src/binutils-2.24/bfd/elf32-arm.c:12387
          /spksrc/toolchain/syno-hi3535-6.2.4/work/arm-cortexa9-linux-gnueabi/bin/../lib/gcc/arm-cortexa9-linux-gnueabi/4.8.3/../../../../arm-cortexa9-linux-gnueabi/bin/ld.bfd: BFD (crosstool-NG 1.20.0) 2.24 assertion fail /home/cpt/hi3535/.build/src/binutils-2.24/bfd/elf32-arm.c:12387
          /spksrc/toolchain/syno-hi3535-6.2.4/work/arm-cortexa9-linux-gnueabi/bin/../lib/gcc/arm-cortexa9-linux-gnueabi/4.8.3/../../../../arm-cortexa9-linux-gnueabi/bin/ld.bfd: BFD (crosstool-NG 1.20.0) 2.24 assertion fail /home/cpt/hi3535/.build/src/binutils-2.24/bfd/elf32-arm.c:12387
          /spksrc/toolchain/syno-hi3535-6.2.4/work/arm-cortexa9-linux-gnueabi/bin/../lib/gcc/arm-cortexa9-linux-gnueabi/4.8.3/../../../../arm-cortexa9-linux-gnueabi/bin/ld.bfd: BFD (crosstool-NG 1.20.0) 2.24 assertion fail /home/cpt/hi3535/.build/src/binutils-2.24/bfd/elf32-arm.c:12387
          /spksrc/toolchain/syno-hi3535-6.2.4/work/arm-cortexa9-linux-gnueabi/bin/../lib/gcc/arm-cortexa9-linux-gnueabi/4.8.3/../../../../arm-cortexa9-linux-gnueabi/bin/ld.bfd: BFD (crosstool-NG 1.20.0) 2.24 assertion fail /home/cpt/hi3535/.build/src/binutils-2.24/bfd/elf32-arm.c:12387
          collect2: error: ld returned 1 exit status
          

error: could not compile `fd-find` (bin "fd") due to previous error

probably this is an issue with the older synology toolchain for hi3535 arch.

for other targets/toolchains the build succeeds:

• x86_64-unknown-linux-gnu
• i686-unknown-linux-gnu
• armv5te-unknown-linux-gnueabi (with fix: Multiple definitions of __sync_fetch_and_add_4 et al. rust-lang/compiler-builtins#420 (comment))
• armv7-unknown-linux-gnueabihf
• aarch64-unknown-linux-gnu
• powerpc-unknown-linux-gnu

Describe what you expected to happen:

No response

What version of fd are you using?

8.7.1

Which operating system / distribution are you on?

Synology toolchain:
- gcc: arm-cortexa9-linux-gnueabi-gcc (crosstool-NG 1.20.0) 4.8.3 20140106 (prerelease)
- ld: GNU ld (crosstool-NG 1.20.0) 2.24

build env:
- Linux spksrc 4.19.0-24-amd64 #1 SMP Debian 4.19.282-1 (2023-04-29) x86_64 GNU/Linux

rust:
- rustc 1.74.0 (79e9716c9 2023-11-13)

[sharkdp]

Thank you. It looks like this is a problem in a dependency (binutils). Do you think it should be reported upstream?