Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should TOML-mapping-implemented file extension globs look like standard supported extensions? #2946

Open
jacg opened this issue Apr 26, 2024 · 0 comments
Open

Should TOML-mapping-implemented file extension globs look like standard supported extensions? #2946

jacg opened this issue Apr 26, 2024 · 0 comments
Labels
feature-request New feature or request

Comments

@jacg
Copy link

jacg commented Apr 26, 2024

This question arose here: #2940 (comment).

Briefly, adding support for .debdiff as an alternative extension for .diff (and .patch) by using the TOML mappings (src/syntax_mapping/builtins/) modifiel the relevant line of the output of bat --list-languages thus

-Diff    diff, patch.
+Diff    diff, patch, *.debdiff.

The *. before debdiff breaks the symmetry, making the TOML-implemented extension look different from the stardard ones. Should they all look the same?
@jacg jacg added the feature-request New feature or request label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jacg