Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: block-toolbar component on blocks page stops working if you click the currently active toggle again #3640

Open
2 tasks done
ItsValerius opened this issue May 1, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ItsValerius
Copy link

Describe the bug

The ToggleGroup component on the blocks page stops working if you click the currently active toggle again.
This is because we pass an empty string to the parseInt function, when the value doesn't change.
Fixing only requires checking if there is a value.
See here in the radix documentation:
https://www.radix-ui.com/primitives/docs/components/toggle-group#ensuring-there-is-always-a-value

Affected component/components

How to reproduce

  1. Go to Blocks page
  2. chose a size
  3. click that size again

Codesandbox/StackBlitz link

No response

Logs

No response

System Info

Windows, Firefox/Chrome

Before submitting

  • I've made research efforts and searched the documentation
  • I've searched for existing issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant