-
Notifications
You must be signed in to change notification settings - Fork 201
Steps to a successful PR
Weiyüen Wu edited this page Mar 26, 2020
·
10 revisions
When submitting a PR, please follow the following steps:
- You finished the code and ensure it has a good quality.
- You rebase the commits onto the newest develop branch, squash the unnecessary PR and reword the commit message, making sure it conforms to the coding rules and is informative as a release note (we generate release note directly from commit messages).
- You submit the PR and fill in the PR template carefully. If any UI changes are involved, include a screenshot in the PR comment to demo. If any issue are closed by this PR, add
closes #<issue-id>
in your PR text. - You wait until CI passes. If CI failed, change the code until CI passes.
- You request a code review from our team members. You get several comments later and change the code to resolve the comments. You also click the resolve button on the comments.
- You rebase, squash and reword the commit, and again you request the code review.
- The reviewer approves your PR and he clicks the
merge
button. - Congratulations! You successfully contribute to dataprep!