Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named instance for mssql connection not working + fix proposition #619

Open
Niivii opened this issue Apr 24, 2024 · 0 comments
Open

Named instance for mssql connection not working + fix proposition #619

Niivii opened this issue Apr 24, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Niivii
Copy link

Niivii commented Apr 24, 2024

What language are you using?

Python

What version are you using?

Latest

What database are you using?

Mssql

What dataframe are you using?

Pandas

Can you describe your bug?

Named instance for mssql are not working

What are the steps to reproduce the behavior?

use connection string with host\instance

Example query / code
import connectorx
print(connectorx.read_sql("mssql://username:password@hostname\MYINSTANCE/mydb;", "select * from myschema.mytable;", index_col="id").to_string())

What is the error?

TO

Named instance never worked as stated in those issues:
#140
#354
#560

The original fix done for 140 was this :
comment: #140 (comment)
commit: bd66558#diff-3f052eef0bfdd71e89a1293a8ecdd4fb351029a0a03f0eff0f8a66940bfd682e

Meanwhile as stated in bb8-tiberius doc I believe the fix should be with using_named_function:

let mgr = bb8_tiberius::ConnectionManager::build(conn_str.as_str())?.using_named_connection();

https://github.com/kardeiz/bb8-tiberius

Sadly I can't propose a PR as I am not a Rust dev.

@Niivii Niivii added the bug Something isn't working label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant