Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

i think this project is very great and i will do some using ur thoughts #87

Open
xx-zhang opened this issue May 18, 2019 · 3 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@xx-zhang
Copy link

proj very great as i see

i think this project is very great and i will do some using ur thoughts such as celery, query, db/config, pentes-tools and so on . i think this tool is similar to Sn1per in some way. Of cource celerystalk is a great idea.

what i think need proved

also i think your framework is not great because of not having a clear ui with it .
i think the db saved not the best way, that not useful for web, of cource we could replace orm/sqlachemy instead of sqllite.

what i have done

python2 is not used for me , and i have forks your proj to the-champions-of-capua/celerystalk using python3 and content of all you achieved have run well in my container except for some celery task with revote and then i'll fix it using my free time.

@sethsec sethsec self-assigned this May 19, 2019
@sethsec sethsec added the enhancement New feature or request label May 19, 2019
@sethsec
Copy link
Owner

sethsec commented May 19, 2019

Thank you so much @xx-zhang! I'm so glad you like the project. I am excited to work with you to help make celerystalk better! I have been meaning to move from python2 to python3, so I really appreciate your help with that. I can't wait to check out your fork and play with it.

I have been working on reworking screenshots lately. I am almost done. What I have noticed is that my screenshot functionality causes high load on aws instances that are small and on small virtual machines.I am going to switch ALL screenshot functionality to be performed by the aquatone project as a celery task, and I will offer two ways to look at screenshots. Option 1, you can look at the aquatone report. Option 2. I am going to use the aquatone pictures within celerystalk report so you can see it the way it looks now, just that the pictures come from aquatone.

Once I fix this screenshot issue I am going to make the number of concurrent celery tasks a user level configuration. That will make much more sense. Even on small instances or virtual machines, I never had problems running 4 concurrent tasks (except for the screenshots).

Anyway, as for the UI, I am interested to hear your suggestions. A while ago I started to build a REPL, similar to the way recon-ng works. If you type celerystalk interactive you will see a preview. Do you think that is better? Or do you think there is a better way? Or do you mean that you would like a visual UI?

I am not very knowledgeable with databases and I have very little experience with and understanding of ORM. Do you have that experience? Maybe you could help me?

@xx-zhang
Copy link
Author

@sethsec as i see, you have thought about it for a long time and then worked this project.

i'm pool in ui. as currently you show is not bad. i'm look forward to your more and more interesting mudules for celerystalk. i belive you can do it well and waiting a wonderful project made from ur hand.

@sethsec
Copy link
Owner

sethsec commented Aug 23, 2019

Hey @xx-zhang - Thank's again for your work in porting celerysalk from python2 to python3. I am porting changes you made in your own fork back to my project now. so thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants