Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass WPT tests for Gamepad and catch up to spec #31362

Open
2 of 4 tasks
msub2 opened this issue Feb 16, 2024 · 1 comment
Open
2 of 4 tasks

Pass WPT tests for Gamepad and catch up to spec #31362

msub2 opened this issue Feb 16, 2024 · 1 comment
Assignees
Labels
A-content/script Related to the script thread A-embedding

Comments

@msub2
Copy link
Contributor

msub2 commented Feb 16, 2024

Once #31200 merges Servo will finally have the ability to use non-XR gamepads. However, there's still work remaining to be fully spec compliant and pass all the existing WPTs. The following tests currently still expect fails:

  • gamepad-default-feature-policy
    • Fails due to the "allow" directive not being supported
  • gamepad-supported-by-feature-policy
    • Fails because it expects document.featurePolicy to exist. Feature Policy has been succeeded by Permissions Policy however, so what really needs to happen is for the test to be changed/updated.
  • idlharness-extensions
    • Fails due to missing implementations for GamepadTouch and GamepadHapticActuator
  • idlharness
    • Fails due to missing GamepadHapticActuator implementation as well as these GamepadEvent issues
      • [GamepadEvent must be primary interface of new GamepadEvent("gamepad")]
      • [GamepadEvent interface: new GamepadEvent("gamepad") must inherit property "gamepad" with the proper type]
      • [Stringification of new GamepadEvent("gamepad")]

The following are the tasks necessary to fix these and be fully spec-compliant:

@msub2
Copy link
Contributor Author

msub2 commented Feb 21, 2024

No longer need to worry about secure context, removing it from the list

@msub2 msub2 changed the title Pass WPT tests for Gamepad Pass WPT tests for Gamepad and catch up to spec Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-content/script Related to the script thread A-embedding
Projects
None yet
Development

No branches or pull requests

2 participants