Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HTMLImageElement decode #31183

Open
gterzian opened this issue Jan 26, 2024 · 10 comments · May be fixed by #31269
Open

Implement HTMLImageElement decode #31183

gterzian opened this issue Jan 26, 2024 · 10 comments · May be fixed by #31269
Assignees
Labels
A-content/images Interacting with images from web content A-content/script Related to the script thread A-network B-interesting-project Represents work that is expected to be interesting in some fashion C-assigned There is someone working on resolving the issue E-candidate-for-mentoring

Comments

@gterzian
Copy link
Member

WebIDL is at https://html.spec.whatwg.org/multipage/embedded-content.html#htmlimageelement

Spec is at https://html.spec.whatwg.org/multipage/embedded-content.html#dom-img-decode

How to do it:

  1. Add the decode member to our WebIDL
  2. Implement the required method on our dom struct

Doing 2 will require integrating the decode concept with the ImageContext and the ImageCache

Look at the async decoding and handling of the data happening in the image cache, and find a way to hook it up to a promise in script.

See also https://html.spec.whatwg.org/multipage/images.html#img-decoding-process

@gterzian gterzian added A-content/images Interacting with images from web content A-network A-content/script Related to the script thread B-interesting-project Represents work that is expected to be interesting in some fashion E-candidate-for-mentoring labels Jan 26, 2024
@Taym95
Copy link
Contributor

Taym95 commented Jan 28, 2024

@servo-highfive assign me

@servo-highfive servo-highfive added the C-assigned There is someone working on resolving the issue label Jan 28, 2024
@servo-highfive
Copy link

Hey @Taym95! Thanks for your interest in working on this issue. It's now assigned to you!

@Taym95 Taym95 linked a pull request Feb 6, 2024 that will close this issue
4 tasks
@KiChjang
Copy link
Contributor

@servo-highfive assign me

@servo-highfive
Copy link

It looks like this has already been assigned to someone. I'll leave the decision to a core contributor.

@KiChjang
Copy link
Contributor

@Taym95 Are you still working on this?

@Taym95
Copy link
Contributor

Taym95 commented Feb 22, 2024

Yes I am working on it, I would like continue working on it if you don't mind

@KiChjang
Copy link
Contributor

That's fine! I assumed it was abandoned when the PR is closed and no activity had been seen for weeks.

@Payne680
Copy link

Payne680 commented Mar 5, 2024

@gterzian Please if no one is working on it, kindly assign it to me, am outreachy intern looking to make some contributions

@Taym95
Copy link
Contributor

Taym95 commented Mar 5, 2024

@gterzian Please if no one is working on it, kindly assign it to me, am outreachy intern looking to make some contributions

Hi @Payne680 there is already a PR

@Payne680
Copy link

Payne680 commented Mar 5, 2024

Ooh alright @gterzian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-content/images Interacting with images from web content A-content/script Related to the script thread A-network B-interesting-project Represents work that is expected to be interesting in some fashion C-assigned There is someone working on resolving the issue E-candidate-for-mentoring
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants