Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy does not work for custom config file #471

Open
jamesgroat opened this issue Aug 12, 2020 · 1 comment
Open

Deploy does not work for custom config file #471

jamesgroat opened this issue Aug 12, 2020 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@jamesgroat
Copy link

When deploying using https://github.com/flowaccount/nx-plugins/tree/master/libs/nx-serverless I get the following error:

Could not find any serverless service definition file.

I think this error is related to the fix that was done here: serverless/serverless#7131 in that this error was thrown by code here which looks very similar to the before code in the linked fix. See https://github.com/serverless/enterprise-plugin/blob/master/lib/deployment/getServerlessFilePath.js#L15

The parameters being passed to the deploy command look like this:

  '--config apps/assets-api/serverless.yml',
  '--location dist/apps/assets-api',
  '--waitUntilTargets ',
  '--stage dev',
  '--function .serverless',
  '--updateConfig false',
  '--root /home/james/project/apps/assets-api']

Calling code is here: https://github.com/flowaccount/nx-plugins/blob/master/libs/nx-serverless/src/builders/deploy/deploy.impl.ts#L90

@jamesgroat jamesgroat changed the title Plugin install does not work for custom config file Deploy does not work for custom config file Aug 12, 2020
@medikoo
Copy link
Contributor

medikoo commented Aug 18, 2020

@jamesgroat if report is influenced by nx-serverless it should be reported there. If you feel that serverless shares the bug, please fill bug report at its repository (reproducible test case should not involve nx-serverless and any other plugins)

@medikoo medikoo added the question Further information is requested label Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants