-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: friendly logging for devOps #995
Conversation
This mode disables the persistent status bar.
@eahefnawy @medikoo could you please check this PR and follow up. this will add a new arg |
Thank you for your feedback. @ole3021
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think best solution would be to rely on feature detection, and do not introduce any option at all.
Animated progress definitely should not be shown in non TTY terminals (and by nature CI runs happen in those).
Therefore I would simply not show progress if !process.stdin.isTTY
. https://nodejs.org/api/tty.html#tty_tty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KimPinot thanks for update.
Still I think more natural would be to have _isTTY
and not _isNotTTY
(?)
I thought it was mostly used when it wasn't isTTY, so I wrote it in negative form, but I guess it wasn't. 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @KimPinot! Looks good to me 👍
@medikoo are we good to process this PR? |
@ole3021 Can you run Lint & Formatting workflows? I forgot run prettier at CLI.js :< |
Will this be merged at some point? so this workaround won't be necessary? Thank you. |
Perhaps the form of PR you mentioned will be more helpful in addressing this goal! |
What has been implemented?
The Pull Request adds features related to overall support for CI/CD and devOps.
Closes #834
Steps to verify
- [ ] Add output forserverless deploy
andserverless info
commandsTodos: