Fix unsupported architecture for MacOS #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this, @GlaceCoding! It would be nice to get this merged. |
|
@reconbot ☝🏻 (I don't know if you watch this repository, I allow myself to ping you.) |
It looks like you're on an older os and xcode? none of my machines or CI have issues with the "other" flags. We've had it setup this way for over 10 years. However, it seems to build fine with this change, it needs some testing. I'd feel more comfortable if I knew the impact of the change but I can't find documentation. It is the way it is because it got that way. |
|
I tried on a Mojave but I thought my teammate had last macbook air version (because they need to do it also) 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
With
OTHER_prefix my macos is not able to build the module with node-gyp. With this fix it is able to build. :)fix: #99