Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-Library screenshot tests executed with Roborazzi do not render shadows for Dialogs ONLY #121

Open
sergio-sastre opened this issue Apr 20, 2024 · 0 comments

Comments

@sergio-sastre
Copy link
Owner

Describe the bug
Even though we enable Hardware native graphics, Cross-Library screenshot tests executed with Roborazzi do not render shadows when screenshot testing dialogs.
It works for Composables and Views though.

Additional context
That happens because in the method snapshotDialog(), The RoborazziScreenshotTestRuleForViewuses drawToBitmap(), which uses Canvas (no elevation).
The best fix for this would be to add an option in RoborazziConfig for the BitmapCaptureMethod, analogue to that of DropshotsConfig, ShotConfig and AndroidTestifyConfig, to choose whether to render with or without elevation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant