This repository has been archived by the owner on Jun 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Why are UIDs included as a label? #9
Comments
Hey @pokab, yeah, it looked like a simple idea to get a traffic usage across sessions at that time but it was definitely not a great idea. |
I've got a working solution pushed in my repository, but not yet in the master branch. Will clean it up later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
If I understand it correctly, UIDs in libreswan are generated dynamically and are always changing.
If this is true, including UIDs in metrics, like this:
is a bad practice since it will cause an unbounded number of unique prometheus time series, as described in https://prometheus.io/docs/practices/naming/ :
Because of this, there should be no label where the value of the label does not come from the configuration file, or is not a fixed value.
So the labels I don't really understand are:
The text was updated successfully, but these errors were encountered: