Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why use case containing rxSwift? #82

Open
tirtavium opened this issue Jun 21, 2020 · 1 comment
Open

Why use case containing rxSwift? #82

tirtavium opened this issue Jun 21, 2020 · 1 comment

Comments

@tirtavium
Copy link

tirtavium commented Jun 21, 2020 •
edited

As far as I know, rxSwift is 3rd party library.
If the use case which is main logic of the app containing 3rd party library.. at the base of the app it's depending on rxSwift.

Meaning that this one is violated clean architecture at the very base.
You can't copy paste the use case and domain without rxSwift library.

And this project lack of unit test as well, unit test is the interface of the domain.
@ShenYj
Copy link
Contributor

ShenYj commented Nov 23, 2021

So what's your MVVM practice scenarios

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tirtavium @ShenYj