Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary static inventory files are not deleted #1133

Open
pavlozt opened this issue Jan 2, 2023 · 1 comment
Open

Temporary static inventory files are not deleted #1133

pavlozt opened this issue Jan 2, 2023 · 1 comment

Comments

@pavlozt
Copy link

pavlozt commented Jan 2, 2023

When using a docker compose with static inventory, the temporary file is not deleted. Therefore, a large number of temporary files are created during operation.

I do not observe such code in defer. Only keys are removed https://github.com/ansible-semaphore/semaphore/blob/dd41d48c9b65782a8509082624b6106fef36cca4/services/tasks/runner.go#L257

Also, I don't fully understand the mechanism of the variable SEMAPHORE_TMP_PATH. Perhaps inventories should be created in this directory, but are not actually created there.

@pavlozt
Copy link
Author

pavlozt commented Jan 2, 2023

it is not so important whether I correctly understood the features of the program settings, but in any case, temporary files should be deleted. So I suggest merging my changes #1134
Dear developers, please let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant