-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a lot of unexpected EOF error when reading from partition #1286
Labels
Comments
Hi! i'm also using segmentio/kafka-go and now I've been also facing this issue now as well. can you help us out? |
I have already product with the PR#1287 over 2 weeks and consumes over 100 billion messges. It's seems working well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
a lot of unexpected EOF error when reading from partition cause here.
kafka-go/reader.go
Lines 1421 to 1433 in 2af3101
I was try to log the detail found that when
highWaterMark + 1 == offset
and remain is 0. newMessageSetReader will return io.EOF(because remain is 0, read head first offset with io.EOF error)kafka-go/conn.go
Lines 859 to 866 in 2af3101
It's cause a lot of error log and conn.Close a lot of recreate connection and TIME_WAIT.
Kafka Version
To Reproduce
Expected Behavior
Don't return error when
highWaterMark + 1 == offset
and remain is 0.Shall we just add
remain == 0
condition ?kafka-go/conn.go
Line 861 in ebca72e
IMO, when remain is 0 return empty is reasonable.
Observed Behavior
Additional Context
The text was updated successfully, but these errors were encountered: