-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overlay for Dialog/SideSheet responds to mouseup even if mousedown has different target #966
Comments
Hey @jasonbarry Thanks for bringing this to our attention. I will start to look into this a little more today |
I looked into this a little bit, and I think I know the cause of the issue (although not the solution).
evergreen/src/overlay/src/Overlay.js Line 258 in e1050a7
Of course, these evergreen/src/overlay/src/Overlay.js Line 229 in e1050a7
This ensures that clicks inside of the So I think what we're seeing is that some browsers (Chrome) use the |
If you click inside a Dialog or SideSheet component, drag your mouse outside of the element to the overlay, and release the mouse, the dialog / sidesheet dismisses.
Steps to repro:
I'd expect the dialog not to respond to the dismissal because the click didn't start on the overlay.
The text was updated successfully, but these errors were encountered: