Wrong content type: "application/json"

[eliasbaixas]

The problem

I am proxying the searchkit requests through a Rails controller, but it breaks because Rails tries to parse the request.body as json (as the content-type: application/json suggests). But JSON.parse(request.raw_body) blows because the body is actually not proper json, its a concatenation of 2 or more json strings, which on itself is not proper json.

Environment

• Searchkit version (or git revision) that exhibits the issue: 4.11.2
• Last Searchkit version that did not exhibit the issue (if applicable):
• Node.js version: 20.6.1
• Typescript version:5.4.5
• ElasticSearch/OpenSearch version: Opensearch 2.11.1

Details

from inspecting the requests and code, the request body sent is built from:

searchkit/packages/searchkit/src/utils.ts

Line 90 in a2b9df6

export const createElasticsearchQueryFromRequest = (requests: SearchRequest[]) => {

and the wrong content-type: application/json is sent from:

searchkit/packages/searchkit/src/Transporter.ts

Line 45 in a2b9df6

'content-type': 'application/json',

Code To Reproduce Issue

Just any searchkit request is technically invalid: if the content-type header is 'application/json' the request body shoud adhere to RFC 7159 and be a proper JSON string (not a newline concatenation).

One way to fix this would be to send application/x-ndjson as content-type.

[eliasbaixas]

There are some examples of using curl to insert records to elasticsearch in the searchkit page, and they correctly use application/x-ndjson content-type:

https://www.searchkit.co/docs/getting-started/setup

[joemcelroy]

yeh i think the fix here is that it needs to send as content-type application/x-ndjson. Will need to test this or happy to accept a PR for it.