-
-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recover
handlers seem to not be executed in the tracing context added by a warp::trace
filter
#1037
Labels
bug
Something isn't working
Comments
It looks like you have the trace layer wrapping |
Aha, yeah, I see. Thanks for pointing that out @seanmonstar . I tried moving it below the
I'll keep playing with it. Thanks for the tip! I'll close this once I'm able to get it working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
Platform
❯ uname -a
Darwin COMP-J4C4P27K9Q 22.4.0 Darwin Kernel Version 22.4.0: Mon Mar 6 20:59:28 PST 2023; root:xnu-8796.101.5~3/RELEASE_ARM64_T6000 arm64
Description
Hey all!
It looks like the
warp::trace
filter doesn't propagate the span information torecover
handlers:If we look at:
https://github.com/vectordotdev/vector/blob/a9c8dc88ce7c35b75ab3d1bf903aca0a6feaee53/src/sources/util/http/prelude.rs#L161-L172
The log that is eventually emitted lacks span information that is added here:
https://github.com/vectordotdev/vector/blob/a9c8dc88ce7c35b75ab3d1bf903aca0a6feaee53/src/sources/util/http/prelude.rs#L158
The span context is present in the request handlers.
Is that expected? Or am I maybe missing something?
The text was updated successfully, but these errors were encountered: