Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error inserting notification methods when no methods defined #176

Open
rattuscz opened this issue Nov 15, 2019 · 0 comments
Open

Error inserting notification methods when no methods defined #176

rattuscz opened this issue Nov 15, 2019 · 0 comments

Comments

@rattuscz
Copy link

I've updated to 1.0.2 version from 0.9 and experienced following problem:

old

if (!options.methods) options.methods = {}
if (!options.methods[name]) {
   options.methods[name] = makeMethod(vueApp, name, options, pluginOptions)
}

vs new

let { methods } = componentOptions
if (!methods) methods = {}
if (!methods[name]) {
methods[name] = makeMethod(vueApp, name, componentOptions)
} else {

so in case the methodds property is missing in Vue config object, new object gets created and methods are assigned there, but this new object is never propagated back to the config so those methods are then not processed by Vue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant