Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: List all previous wifi connections stored #28

Open
inglesuniversal opened this issue Jan 30, 2021 · 6 comments
Open

Feature Request: List all previous wifi connections stored #28

inglesuniversal opened this issue Jan 30, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@inglesuniversal
Copy link

and then generate QRCode for the one(s) requested.

Thanks

@sdushantha sdushantha added the enhancement New feature or request label Jan 30, 2021
@pelonchasva
Copy link
Contributor

Hi @sdushantha ,

I was looking into this feature since I thought of the same thing about listing stored wifi connections, I made some changes in another branch, I think it is working fine, my only issue is that I don't have a way to test either on Linux or Mac, so I cannot add the proper commands for those specific platforms.

Is it ok if I create a PR for you to review it and then we can decide how to implement the rest for the missing platforms?

@inglesuniversal
Copy link
Author

Hope you get it done.. it would be amazing!!!

Just the idea that a single command prints out the QR for the wifi is out of this world!!!

@sdushantha
Copy link
Owner

@pelonchasva Creating a PR would be great! I could work on the macOS section and if someone who uses Linux is willing to help out and implement this feature for Linux, then we'll be good to go!

@xr18b
Copy link

xr18b commented Aug 24, 2021

Hi @sdushantha

I've downloaded your code and added a function to list all known SSIDs for Linux (validated on Debian 11.0), Mac OS (validated on Catalina 10.15.7) and Windows (purely theoretical as I don't have a Windows machine at hand).

But as I'm new to GIT, I've only committed my changes locally as for now as I don't want to mess your project by pushing somewhere I'm not supposed to.
How should I proceed to propose you my modifications?

Cheers,

:9,

@sdushantha
Copy link
Owner

Hi @3a392c,

If you want to suggest an edit, what you can do is to fork this repo by clicking on the "Fork" button on the top right corner.
Then, download your copy of the repo. Make the changes and then git push to your copy of the repo.
Once you have done that make a "Pull Request".

Let me know if you need further explaination :)

@pelonchasva
Copy link
Contributor

I just opened a PR to include the set of changes required for this feature to work, please review them and let me know how it works.

sdushantha added a commit that referenced this issue Dec 26, 2022
Feature #28: List stored network (Windows, Linux and MacOS)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants