Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is awesome! I wonder if we can make it a brew formula! #1

Open
mickeypash opened this issue Jan 25, 2021 · 6 comments
Open

This is awesome! I wonder if we can make it a brew formula! #1

mickeypash opened this issue Jan 25, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@mickeypash
Copy link

mickeypash commented Jan 25, 2021

Found some details here: https://docs.brew.sh/Homebrew-and-Python

Let me know if you like the idea! I can have a look to see what it takes and raise a PR.

@sdushantha sdushantha added the enhancement New feature or request label Jan 26, 2021
@sdushantha
Copy link
Owner

Hi @mickeypash,

I'm glad that you liked this project!

Creating a brew formula would be great but we would encounter a conflict in the formula name as there already exists a formula named wifi-password. That formula belongs to this project: https://github.com/rauchg/wifi-password

I updated the README a couple of minutes ago:

This project is an improvement of wifi-password created by @rauchg, where I have added support for multiple platforms and have added the feature for generating QR codes.

Since we already have this project on PyPi and is installable through pip, I think it would be best to drop the idea of creating a brew formula because pip is multiplatform while brew is only for macOS.

Let me know what your thoughts are on this :)

@mickeypash
Copy link
Author

Oh that's great! Thanks for the clarification!
I wonder if it's possible to claim that namespace wifi-password assuming it's backwards compatible with the existing one?
The reason I suggested brew is I think there are many folk that prefer it as an interface to installing globally accessible packages. I personally tend to avoid pip installing anything in my user or system wide using pip as I'm worried about version conflicts.

@sdushantha
Copy link
Owner

Yes, I too prefer to use the system's package manager.

I unfortunately do not have enough time to prioritize this, so would you like to have a go at creating a brew formula for this?

@Samuel-Martineau
Copy link

I think you could also add something to the name of the formula (eg: wifi-password-utility or wifi-password-plus)

@dawidd6
Copy link

dawidd6 commented Jan 27, 2021

while brew is only for macOS

Homebrew also works on Linux FYI:
https://docs.brew.sh/Homebrew-on-Linux

This project won't be accepted in homebrew-core at that state, because it has less than 75 stars at the moment. You can consider creating a tap for it though:
https://brew.sh/2020/11/18/homebrew-tap-with-bottles-uploaded-to-github-releases/

Update: nvm, project has over 100 stars now, it could make its way to the core tap.

sdushantha pushed a commit that referenced this issue Jan 28, 2021
@blaadje
Copy link

blaadje commented Jan 31, 2021

Having nix package would be awesome as well, as the other wifi-password has cc https://search.nixos.org/packages?channel=20.09&show=wifi-password&from=0&size=50&sort=relevance&query=wifi-password

sdushantha pushed a commit that referenced this issue Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants
@mickeypash @dawidd6 @blaadje @sdushantha @Samuel-Martineau and others