New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
diffeditor borders are visually disruptive #304
Comments
Thanks, I was also wondering how to fix this, as the thick lines in the diff editor are quite annoying and ugly. I hope this change makes it into the theme, as it is much better like this. |
You should open a PR for this! I stopped using this theme because of this issue. Thanks for figuring it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Screenshots
the (quite bright) borders between the lines make it quite difficult to concentrate on the diff lines itself, when it's a diff of more than 2 lines.
The borders themselfs are caused by
diffEditor.insertedTextBorder
anddiffEditor.removedTextBorder
- however setting them to transparent (or any other color) will only make them stand out less, not remove them completely (i suspect it's something in vscode that causes this overlap if border-properties are set).The only way i found to get rid of them is to edit the original file (in my case
~/.vscode/extensions/sdras.night-owl-2.0.1/themes/Night\ Owl-color-theme.json
), and remove these attributes from the file (colorCustomizations don't seem to allow unsetting these properties).The result will look as follows - which i think is a lot less intrusive, and makes the text/diff stand out a lot more.
If desired, i can make a PR removing this (i feel this small change will make this Theme perfect).
The text was updated successfully, but these errors were encountered: