Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with single column #87

Open
dekairi opened this issue Nov 13, 2019 · 3 comments
Open

Problems with single column #87

dekairi opened this issue Nov 13, 2019 · 3 comments

Comments

@dekairi
Copy link

dekairi commented Nov 13, 2019

When set column quantity to 1 (+ 5 rows by default). The grid shows on preview 1 row with 5 columns, instead of 1 column and 5 rows. The code in the "Your Grid Code" is correct.
In Dev Tools you can see grid-template-columns: repeat(5, 1fr);, must be grid-template-columns: 1fr;

@kavisherlock
Copy link

kavisherlock commented Nov 17, 2019

Are you sure? Unless it was recently fixed (the last commit to master was over a month ago), I don't see what you're describing.
I see one column with five rows, and the html for the grid section element has style attribute = "grid-template-columns: 1fr; grid-template-rows: repeat(5, 1fr); gap: 0px;"

image

Maybe you're looking at an older version?
Or maybe the real bug is what you did prior to setting the column as one that broke something in the logic?

@dekairi
Copy link
Author

dekairi commented Nov 18, 2019

This issue appears in Safari only. Now I've checked in Firefox and everything works perfectly.
Safari Version 13.0.3 (13608.3.10.10.1)

@kavisherlock
Copy link

Yup. I see it now. It is very interesting. Only happens when I select 5 and replace it with a 1. If I backspace and then type 1 it's fine. I wonder if it has something to do with VueX incorrectly updating the store in Safari. Weird that it only happens with 1 though. Will have to investigate more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants