Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking "Reset Grid" appears to disable the click & drag motion #56

Open
SeanKilleen opened this issue Jun 8, 2019 · 5 comments · May be fixed by #107
Open

Clicking "Reset Grid" appears to disable the click & drag motion #56

SeanKilleen opened this issue Jun 8, 2019 · 5 comments · May be fixed by #107
Labels
bug Something isn't working

Comments

@SeanKilleen
Copy link

Thanks for this awesome site! Dropping this here to start my own investigation and I figure someone else may beat me to the fix, which is fine.

Reproduction

  • Open the site (in my case, in Chrome)
  • Click and drag to create a div
  • Click "Reset Grid" button
  • Attempt to drag over another region to start again

Expected behavior: Drawing still works
Actual behavior: Don't seem to be able to click & drag anywhere anymore

Note: the behavior also happens if I click the x on the div prior to resetting the grid. Anytime the button is clicked, it appears the click/drag functionality stops working as well.

No errors in the console or anything that points to an obvious culprit (for me at least).

Screen Capture

2019-06-08_CSSGridGenerator_ResetIssue
@SeanKilleen
Copy link
Author

Further investigation:

After building locally and looking at the Vue tools, it looks like once the reset button is clicked, I don't see anything else happening in Vuex; no more addChildren calls are made.

My theory so far (relatively new to Vue) is that the call in store.js to state.childarea = []; is removing something that Vue is listening to by creating a new array rather than emptying the existing array.

@SeanKilleen
Copy link
Author

SeanKilleen commented Jun 8, 2019 •
edited

OK, getting a little closer to the actual issue:

It looks like when I click & drag over any one portion of the grid, and then I either click the x on that particular box or click reset, the boxes are removed but the grid doesn't treat that area like it's draggable anymore. It's like the click & drag functionality still has the memory of that box somewhere.

@wpbetterpages
Copy link

wpbetterpages commented Jul 18, 2019 •
edited

Hi,

I am facing the same issue. I don't understand vue one bit but can say that when I click on "What does this project do" link it sometimes works properly, otherwise the click and drag gets blocked. I wonder why that is.

Refreshing the page does work so maybe on clicking reset we could do refresh the page and then use this?

Any thoughts from developer or someone else?

Regards,

@sdras
Copy link
Owner

sdras commented Oct 6, 2019

Interesting, sorry about that. Definitely a bug. I'm swamped for the next few months but I will look into this as soon as I can. Open to PRs as well.

@sdras sdras added the bug Something isn't working label Oct 6, 2019
@SeanKilleen
Copy link
Author

No need to be sorry! :) I'll see if I can PR it; it is Hacktoberfest after all..

@mvfsillva mvfsillva linked a pull request Mar 24, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Reset grid error mvfsillva/cssgridgenerator
3 participants
@SeanKilleen @sdras @wpbetterpages