Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test for prometheus (aggregation) #2233

Closed
tchaikov opened this issue May 9, 2024 · 0 comments · Fixed by #2237
Closed

add test for prometheus (aggregation) #2233

tchaikov opened this issue May 9, 2024 · 0 comments · Fixed by #2237
Assignees
@tchaikov

Comments

@tchaikov
Copy link
Contributor

tchaikov commented May 9, 2024

for instance, we need to have better coverage of the feature introduced by #2219
@tchaikov tchaikov mentioned this issue May 9, 2024
Open
1 task
tchaikov added a commit to tchaikov/seastar that referenced this issue May 10, 2024
@tchaikov
tests: add test for prometheus exporter
0fddb35 
Fixes scylladb#2233
Signed-off-by: Kefu Chai <[email protected]>
tchaikov added a commit to tchaikov/seastar that referenced this issue May 10, 2024
@tchaikov
tests: add test for prometheus exporter
8d65fc1 
unlike metrics_test.cc, prometheus_test exercises the exporter server,
so it tests the different query parameters supported by it.

Fixes scylladb#2233
Signed-off-by: Kefu Chai <[email protected]>
tchaikov added a commit to tchaikov/seastar that referenced this issue May 10, 2024
@tchaikov
tests: add test for prometheus exporter
dd543f8 
unlike metrics_test.cc, prometheus_test exercises the exporter server,
so it tests the different query parameters supported by it.

Fixes scylladb#2233
Signed-off-by: Kefu Chai <[email protected]>
@tchaikov tchaikov mentioned this issue May 10, 2024
Merged
@tchaikov tchaikov self-assigned this May 10, 2024
tchaikov added a commit to tchaikov/seastar that referenced this issue May 10, 2024
@tchaikov
tests: add test for prometheus exporter
1d37268 
unlike metrics_test.cc, prometheus_test exercises the exporter server,
so it tests the different query parameters supported by it.

Fixes scylladb#2233
Signed-off-by: Kefu Chai <[email protected]>
tchaikov added a commit to tchaikov/seastar that referenced this issue May 10, 2024
@tchaikov
tests: add test for prometheus exporter
b00a0e8 
unlike metrics_test.cc, prometheus_test exercises the exporter server,
so it tests the different query parameters supported by it.

Fixes scylladb#2233
Signed-off-by: Kefu Chai <[email protected]>
tchaikov added a commit to tchaikov/seastar that referenced this issue May 10, 2024
@tchaikov
tests: add test for prometheus exporter
bf9da80 
unlike metrics_test.cc, prometheus_test exercises the exporter server,
so it tests the different query parameters supported by it.

Fixes scylladb#2233
Signed-off-by: Kefu Chai <[email protected]>
tchaikov added a commit to tchaikov/seastar that referenced this issue May 10, 2024
@tchaikov
tests: add test for prometheus exporter
fa917ca 
unlike metrics_test.cc, prometheus_test exercises the exporter server,
so it tests the different query parameters supported by it.

Fixes scylladb#2233
Signed-off-by: Kefu Chai <[email protected]>
tchaikov added a commit to tchaikov/seastar that referenced this issue May 12, 2024
@tchaikov
tests: add test for prometheus exporter
f0c8fdc 
Fixes scylladb#2233

Signed-off-by: Kefu Chai <[email protected]>
@xemul xemul closed this as completed in 606e022 May 13, 2024
xemul added a commit that referenced this issue May 13, 2024
@xemul
Merge 'tests: add test for prometheus exporter' from Kefu Chai
9c42116 
unlike metrics_test.cc, prometheus_test exercises the exporter server, so it tests the different query parameters supported by it.

Fixes #2233
Signed-off-by: Kefu Chai <[email protected]>

Closes #2237

* https://github.com/scylladb/seastar:
  tests: add test for prometheus exporter
  tests: move apps/metrics_tester to tests/unit
  apps/metrics_tester: keep metrics with "private" labels
  apps/metrics_tester: support "labels" in conf.yaml
  apps/metrics_tester: stop server properly
  apps/metrics_tester: always start exporter
  apps/metrics_tester: fix typo in conf-example.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tchaikov tchaikov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: add test for prometheus exporter tchaikov/seastar
1 participant
@tchaikov