Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic metric aggregation #2220

Open
nvartolomei opened this issue May 4, 2024 · 0 comments
Open

Dynamic metric aggregation #2220

nvartolomei opened this issue May 4, 2024 · 0 comments

Comments

@nvartolomei
Copy link
Contributor

In Seastar, metrics can be defined with implicit aggregation by specific labels, which occurs at query time. This feature is useful, for instance to define metrics per shard or even more finely grained per an application-defined entity while reporting them in a more aggregated manner, such as sum or histogram per server.

However, there are times when it is necessary to inspect the fine-grained metrics. I'm sending a PR to allow disabling this aggregation and get the "raw" metrics by adding __aggregate__=false to the query string. #2219


Separately, what do we think about adding dynamic aggregation capabilities.

E.g.

  • aggregate[query_latency]=false to disable aggregation just for query_latency metric
  • aggregate[query_latency]=-table to remove table label from aggregation; i.e. report metric per database table
  • etc.

Thoughts?

@amnonh @StephanDollberg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant