-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding modality to MuData.mod #46
Comments
Thank you, @racng! As this seems to be a warning, it shouldn't generally stand in the way of adding modalities. So far I see that this warning might be related to a scenario when the feature names are duplicated across modalities. In that case With no name duplicates, there should be no problem like this and no warning! Version 0.3 of |
avoid name (pandas index) sorting when adding new modalities. Resolves #46.
Is your feature request related to a problem? Please describe.
After loading a CITE-seq 10x h5 file with muon and 10x vdj file with scirpy, I tried adding the AIRR modality to the existing mdata by adding it to
mdata.mod
. It seemed to work, since mdata shows that it has 3 modalities. However, when I tried to write the mdata, I get an error:However, there is no error if i initialize a new mdata object with all three modalities and save that.
Describe the solution you'd like
Would be nice if we can add a modality with
mdata.mod['airr'] = adata.copy()
without causing warnings.Describe alternatives you've considered
We currently need to create a new object whenever we want to add a new modality
Additional context
Full error message when saving the
mdata
after addingadata
tomdata.mod
The text was updated successfully, but these errors were encountered: