Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smooth scrolling ignores "skipOverflowHiddenElements" #822

Open
lyle45 opened this issue Apr 21, 2020 · 1 comment
Open

Smooth scrolling ignores "skipOverflowHiddenElements" #822

lyle45 opened this issue Apr 21, 2020 · 1 comment

Comments

@lyle45
Copy link

lyle45 commented Apr 21, 2020

When scrolling with this package with behavior = "smooth", skipOverflowHiddenElements is not passed down to scroll-into-view-if-needed making it misbehave

code should extend and pass down all options while overwriting only behavior option with function
scrollIntoView(target, {...option, behavior: function(){...}

@lyle45
Copy link
Author

lyle45 commented Apr 21, 2020

@stipsan This is a one line fix, any chance to help me i nthe close time?

Thanks in advance :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant