Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Liquid function newline_to_br #374

Open
richard-browne opened this issue Aug 17, 2021 · 3 comments
Open

Missing Liquid function newline_to_br #374

richard-browne opened this issue Aug 17, 2021 · 3 comments

Comments

@richard-browne
Copy link

richard-browne commented Aug 17, 2021

Scriban seems to be missing Liquid functions such as 'escape' and 'newline_to_br'. I know there is eg 'html.escape', but when using ParseLiquid() compatibility mode, I think one would reasonably expect the standard Liquid functions to work?

@richard-browne richard-browne changed the title Missing Liquid escape function Missing Liquid functions such as escape/newline_to_br Aug 17, 2021
@richard-browne richard-browne changed the title Missing Liquid functions such as escape/newline_to_br Missing Liquid function newline_to_br Aug 19, 2021
@richard-browne
Copy link
Author

I figured out that I need to use LiquidTemplateContext with ParseLiquid(). Then most of the liquid functions are defined. However, newline_to_br is still missing. Please consider adding it. Even ignoring liquid compatibility, the html.newline_to_br filter is a missing feature for scriban.

@xoofx
Copy link
Member

xoofx commented Aug 22, 2021

PR Welcome, personally to sparetime left and little interest in better supporting Liquid in Scriban (Liquid in Scriban is more considered as a transition but I would not recommend to use Scriban for a Liquid syntax.runtime if you really want 100% compatibility)

@richard-browne
Copy link
Author

Ok but ignoring Liquid.. as a feature request a html.newline_to_br function is missing for the main language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants