-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
canonicalize_url incorrectly handles port when using hostname that requires IDNA encoding #222
Comments
I also discovered one more related thing with multiple dots in the end of the domain:
As you can see, single dot is handled properly, but with 2+ dots it doesn't encode the domain at all. Update: it seems to be an invalid url according to the standard, so maybe the behavior is correct, though in other languages some url validators accept it and handle normally. So not sure if this addendum has to be fixed, I'll revert the title back. |
Hello,
We just recently encountered the following problem:
which returns
https://xn--e1aybc.xn--:33-qdd4dec/
while the expected value is
https://xn--e1aybc.xn--e1aybc:33/
And that happens to every hostname that required IDNA encoding for their TLD.
Could you please fix this behavior?
The text was updated successfully, but these errors were encountered: