-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import of old scrapylib processor functions? #41
Comments
I would not mind having them as built-in processors. And since we added jmespath as a dependency, I’m not sure if adding dateutil would be an issue. Maybe it could be added optionally. Not a strong opinion either way, though. |
No strong opinion as well. Optional install are fine, but they must be clear in the docs, specially in the functions that rely on the optional install |
Old
scrapylib
had a few ItemLoader processors that were dropped with the codebase.I preserved them here when scrapylib repo disappeared.
Mostly date/time parser handling and some cleaners. I wonder if they'd be useful to add here - or not. (Are they duplicating features that are elsewhere and I may have overlooked?)
I could see them become a namespace such as
itemloaders.processors.extra
- which wouldn't be auto-imported withitemloaders.processors
and could have external dependencies that don't automatically become required - such as the dateutil parser lib used here?Or perhaps name it
itemloaders.processorlib
- as in stdlib - for a place to have a few generically useful processor functions?But perhaps it's also okay if they just disappear. I'm not sure, really.
The text was updated successfully, but these errors were encountered: