Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify parent/chained tokens support #148

Open
jbasney opened this issue Mar 16, 2022 · 1 comment
Open

Clarify parent/chained tokens support #148

jbasney opened this issue Mar 16, 2022 · 1 comment

Comments

@jbasney
Copy link
Member

jbasney commented Mar 16, 2022

I think d30cb10 removed the parent/chained tokens support, but README.rst says

NOTE: SciTokens (the format and this library) is currently being designed; this README describes how we would like it to work, not necessarily current functionality. Particularly, we do not foresee the chained tokens described here as part of the first release's functionality.

and

SciTokens can be chained, meaning one token can be appended to another:
token = scitokens.SciToken(parent=parent_token)
The generated object, token, will default to having all the authoriations of the parent token - but is mutable and can add further restrictions.

and there's still a parent parameter

:param parent: Parent SciToken that will be chained

Since there have been 10+ releases, I'd like to update that NOTE in the README to be clearer about the stability of the format/library and remove the references to parent/chained tokens unless that's still supported/planned.

I can make a pull request, but I wanted to check first.

@djw8605
Copy link
Contributor

djw8605 commented Sep 26, 2022

Oddly, just saw this. Yes, feel free to make a pull request. The parent changed tokens is not supported, never was supported, and is not planned to be supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants