Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion not to download the whole SDK but only the required library #56

Open
8ctopus opened this issue Nov 14, 2021 · 3 comments
Open

Comments

@8ctopus
Copy link

8ctopus commented Nov 14, 2021

I've noticed that only the sciter library is actually required for pysciter to work so it would be possible to use a small script to download the necessary files. Here's an example
Let me know if you're interested, I'll happily make it.

@8ctopus
Copy link
Author

8ctopus commented Nov 14, 2021

I ended up doing anyway https://github.com/8ctopus/pysciter-example

@pravic
Copy link
Member

pravic commented Nov 15, 2021

Yeah. In fact, that is exactly what we do in CI:

pysciter/.travis.yml

Lines 58 to 60 in f5f0011

- export SDK_PATH=https://raw.githubusercontent.com/c-smile/sciter-sdk/master
- if [ "$TRAVIS_OS_NAME" = "linux" ]; then curl -so "$TRAVIS_BUILD_DIR/libsciter-gtk.so" $SDK_PATH/bin.lnx/x64/libsciter-gtk.so; fi
- if [ "$TRAVIS_OS_NAME" = "osx" ]; then curl -so "$TRAVIS_BUILD_DIR/libsciter.dylib" $SDK_PATH/bin.osx/libsciter.dylib; fi

@8ctopus
Copy link
Author

8ctopus commented Nov 15, 2021

Thanks for sharing, I see now.

IMO it would suggest remove the requirement to download the whole SDK from the README and add it to the path.
Maybe just me, but I don't like big downloads and adding things to PATH. The script installation would provide an alternative.

Also I don't understand what you mean by

...install Sciter shared library to your LIBRARY_PATH.

What's your opinion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants