New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider bumping C standard in meson.build from C99 to C17 #28977
Labels
Bug
free-threading
PRs and issues related to support for free-threaded CPython (a.k.a. nogil or no-GIL, PEP 703)
Comments
But seeing C99 makes me happy cause I grew up with it 😅 Otherwise, we have a bunch of code which we don't really maintain much (they're basically vendored). If bumping doesn't break those, I don't see why we wouldn't. I think opening PR to check if things would move smoothly would be welcomed :) |
lesteve
added
the
free-threading
PRs and issues related to support for free-threaded CPython (a.k.a. nogil or no-GIL, PEP 703)
label
May 13, 2024
I assume that we can close this issue since #28980 has been merged, isn't it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
free-threading
PRs and issues related to support for free-threaded CPython (a.k.a. nogil or no-GIL, PEP 703)
Describe the bug
Currently, trying to build scikit-learn with the python 3.13 free-threaded build leads to a compilation error related to usage of
static_assert
in CPython internals. This leaks into public code via cython's adding#include "internal/pycore_frame.h"
to module init code.See scipy/scipy#20515 where scipy made a similar change for similar reasons.
C17 is well-supported by downstream compilers, including MSVC. CPython itself is built with C11, which is a superset of C17.
Opening this as an issue instead of just making a pull request to see if there are good reasons besides inertia why
meson.build
specifies C99.Steps/Code to Reproduce
python -m pip install -v . --no-build-isolation
Expected Results
successful build
Actual Results
Versions
Current `main` branch.
The text was updated successfully, but these errors were encountered: