Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add classes attribute and test for CalibratedClassifierCV #187

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] Add classes attribute and test for CalibratedClassifierCV #187

wants to merge 2 commits into from

Conversation

wdevazelhes
Copy link
Member

@wdevazelhes wdevazelhes commented Mar 21, 2019 •
edited

Fixes #173

TODO:

  • Add references in the doc

William de Vazelhes added 2 commits March 21, 2019 11:20
Add classes attribute and test for CalibratedClassifierCV
7f1373c
Merge branch 'master' into feat/calibrated_classifier_cv
b2396e5 
# Conflicts:
#	metric_learn/base_metric.py
#	metric_learn/itml.py
#	metric_learn/sdml.py
#	test/test_sklearn_compat.py
@wdevazelhes wdevazelhes added this to the v0.6.0 milestone May 21, 2019
@wdevazelhes
Copy link
Member Author

I put this for v0.6.0, since we need scikit-learn v0.21 for the test to pass.

@bellet
Copy link
Member

bellet commented Dec 13, 2019

@wdevazelhes can we revive this?

@bellet bellet modified the milestones: v0.6.0, v0.7.0 Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.

Ensure that CalibratedClassifierCV works
2 participants
@wdevazelhes @bellet