-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filters.laplace result has the wrong sign #7357
Labels
Comments
pitkajuh
pushed a commit
to pitkajuh/scikit-image
that referenced
this issue
Apr 3, 2024
pitkajuh
pushed a commit
to pitkajuh/scikit-image
that referenced
this issue
Apr 13, 2024
pitkajuh
pushed a commit
to pitkajuh/scikit-image
that referenced
this issue
Apr 13, 2024
pitkajuh
pushed a commit
to pitkajuh/scikit-image
that referenced
this issue
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description:
The purpose of a Laplace filter is to compute an approximation for the second derivative. Which means that at the position of a maximum, it should give us back a negative number. That is e.g. the behavior of the scipy implementation of a Laplace filter. The filter matrix in skimage is inverted.
Fixing this bug will break the workarounds some people might have used in the past (i.e. multiplying the skimage result with minus 1).
Way to reproduce:
Version information:
The text was updated successfully, but these errors were encountered: