-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FAST autocomplete is broken #1916
Comments
Hm, the file that implements autocomplete does a:
Under webpacker, that was enough to make a jquery |
Hm. We could copy and paste that jquery plugin to a local file, and edit it's loading code to work. We could switch to a whole different autocomplete implementation (that one isn't very actively maintained, and requires jquery; although it works well). Blacklight just switched to: https://github.com/github/auto-complete-element It would require some changes to switch to that one -- uses web components, so markup changes. Server is expected to return actual HTML, not json. But it would probably work in the end? |
Huh, while it also hasn't been maintained in forever, there may be a non-jQuery autocomplete alternative from the same source that may import properly and require few code changes.... https://github.com/devbridge/Vanilla-Autocomplete Very limited docs though. Also seems to maybe not be released to npm, annoying. |
… released one We couldn't figure out how to get our vite setup to load it properly otherwise. See #1916 and devbridge/jQuery-Autocomplete#843 We don't love this whole autocomplete implementation, but keep it working for now. Haven't found any alternatives we love. Extensive comments left in source on analysis of tech issues and options.
Another one we could maybe switch to in future: https://github.com/digitalfortress-tech/typeahead-standalone |
Maybe broke as part of our vite migration?
When I type in the should-be-autocompleted
subject
field on production, I get this JS error in dev console:The text was updated successfully, but these errors were encountered: