Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase out MANIFEST.in #83

Open
schuderer opened this issue Mar 3, 2020 · 0 comments
Open

Phase out MANIFEST.in #83

schuderer opened this issue Mar 3, 2020 · 0 comments
Labels
hygiene The code could be better, or better managed

Comments

@schuderer
Copy link
Owner

schuderer commented Mar 3, 2020

Currently, ML Launchpad's source distribution (sdist) pretents to be a sorta-kinda-half development tarball.

It isn't. It's a distribution, meant to be installed, not developed on. For the latter, people can clone its GitHub repo.

ML Launchpad library does not use or need any non-.py files to be installed properly.

And the examples folder should be separate. It can already be downloaded separately now. (Edit: Not true right now - whoops 😬)

So: no tests, no packaging of build config stuff, and the reward will be: no MANIFEST.in (one less config file is a good thing).

Rationale (up until, but excluding the point they recommend to include everything under version control in the source distribution): https://www.remarkablyrestrained.com/python-setuptools-manifest-in/

@schuderer schuderer added the hygiene The code could be better, or better managed label Mar 3, 2020
@schuderer schuderer changed the title Phase out MANIFEST.ini Phase out MANIFEST.in Mar 3, 2020
@schuderer schuderer added this to To do in Prioritized User Issues via automation May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hygiene The code could be better, or better managed
Projects
Development

No branches or pull requests

1 participant