Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor mllaunchpad.api #125

Open
schuderer opened this issue Jul 6, 2020 · 0 comments
Open

Refactor mllaunchpad.api #125

schuderer opened this issue Jul 6, 2020 · 0 comments
Labels
hygiene The code could be better, or better managed

Comments

@schuderer
Copy link
Owner

Description

The module mllaunchpad.api could be easier to maintain than it is now (v1.0.0).

One reason is that duplicates code from mllaunchpad.model_actions, in a way that makes it hard to test and expand. Also, the separation of concerns between objects and functions appears wonky in some places. Maybe the way we use Flask-Restful's resources etc. is one reason for this/could be improved (right now, mixing types of resources lead to some intermingling and more if-else constructs than I personally find appealing).

All of this also the reason that unit tests on api are currently somewhat lackluster and branch coverage is lower compared to other parts of the code base.

@schuderer schuderer added the hygiene The code could be better, or better managed label Jul 6, 2020
@schuderer schuderer added this to To do in Prioritized User Issues via automation May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hygiene The code could be better, or better managed
Projects
Development

No branches or pull requests

1 participant