-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing test on non x86 architectures #103
Comments
Can you submit a PR to fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi @schollz
Thanks for your work on progressbar :)
However, while running tests on !x86 architectures, one of the test fails -- in particular this one:
On investigating further, it seems that the value of rightBrac is turning out to be negative. On further investigation, it is found that the value of the
averageRate
variable is "0" for this particular test, and hence a division by 0 is happening there, which results in a +Inf, now the rest of the operations convert this into 0s on x86 and -1 on rest arches.Here's a sample code for instance:
Output on x86: 0s
Output on arm64/other arches: -1s
For now, I've applied this patch to force a 0s value if rightBrac is 0s:
But I admit this might not be the best way to get around it. Please consider fixing this
The text was updated successfully, but these errors were encountered: