Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced Text Editor Functionality #21

Closed
kennyparsons opened this issue Jun 25, 2020 · 8 comments
Closed

Enhanced Text Editor Functionality #21

kennyparsons opened this issue Jun 25, 2020 · 8 comments
Labels
enhancement New feature or request
Projects

Comments

@kennyparsons
Copy link

Would be great if the text editor was enhanced to support things like tabbing and basic syntax highlighting. Syntax highlights can be accomplished with https://highlightjs.org/

@TheFehr
Copy link

TheFehr commented Jun 25, 2020

Can highlightjs highlight editable text?

@kennyparsons
Copy link
Author

No, but the recommended method is to built the text editor + a preview. Much like github comments work. The "Write" tab and "Preview" tab.

The idea behind syntax highlighting is it can help identify errors in the nginx .conf file. Sublime text editor offers this and it's helped me quite a bit, as I often forget punctuation marks to complete each line.

@LucaNerlich
Copy link
Contributor

tbh, I think most of the time, the config will be written elsewhere and copy pasted into anyways.

@foozzi
Copy link

foozzi commented Jun 26, 2020

Would be great if the text editor was enhanced to support things like tabbing and basic syntax highlighting. Syntax highlights can be accomplished with https://highlightjs.org/

Today I’ll try to finish the syntax highlighting and send pull request

@schenkd schenkd added the enhancement New feature or request label Jun 26, 2020
@schenkd
Copy link
Owner

schenkd commented Jun 26, 2020

Hey @kennyparsons, great proposal with the multiple tabs. Had already started a first attempt with highlightjs in realtime to highlight the written code but this was connected with too many side-effects. Tab support is already solved by me and will be in the next release. If @foozzi implements a solution for hightlightning I will be happy to have a look at it.

@foozzi
Copy link

foozzi commented Jun 26, 2020

#24
sorry for 2 commits, forgot to remove the 'print()'

@schenkd and please delete this line a65f145#diff-d13e648c450173d77b5e04da795274fdR17
cdn link for older styles

@schenkd schenkd added this to In progress in Version 0.3 Jun 28, 2020
@schenkd schenkd moved this from In progress to To do in Version 0.3 Jun 28, 2020
@schenkd schenkd moved this from To do to In progress in Version 0.3 Jun 28, 2020
@causefx
Copy link

causefx commented Jul 12, 2020

You should really look into this library....
https://ace.c9.io/
It is wonderful....

EDIT: Nevermind, looks like foozzi implemented that library. GJ

@honeyspoon
Copy link

maybe we could use Monaco the vscode editor

@kennyparsons kennyparsons closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Version 0.3
  
In progress
Development

No branches or pull requests

7 participants