Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement Request: Add "systemctl restart nginx" button #14

Open
LucaNerlich opened this issue Jun 24, 2020 · 9 comments
Open

Enhancement Request: Add "systemctl restart nginx" button #14

LucaNerlich opened this issue Jun 24, 2020 · 9 comments
Assignees
Labels
enhancement New feature or request
Projects

Comments

@LucaNerlich
Copy link
Contributor

LucaNerlich commented Jun 24, 2020

It would be great, if someone could add a button which executes systemctl restart nginx on the underlying machine.
Then everything nginx related could be handled via this ui.

As of right now, I need to edit something AND login via ssh and restart nginx for the changed to come into effect.

Thanks for the great work so far :)

@LucaNerlich LucaNerlich changed the title Enhancement Request: Enhancement Request: Add "systemctl restart" button Jun 24, 2020
@TheFehr
Copy link

TheFehr commented Jun 24, 2020

Wouldn't nginx reload make more sense? This would make sure you don't end up with a nginx that won't start because of syntax errors.

@LucaNerlich
Copy link
Contributor Author

LucaNerlich commented Jun 24, 2020

Well, ideally youd build the output of ‚nginx -t‘ into the you as well. Or add a button ‚check‘ and restart/reload afterwards.

True, good point.

@kennyparsons
Copy link

nginx -s reload would be ideal, to make sure nginx falls back if the new configuration fails.

@TheFehr
Copy link

TheFehr commented Jun 24, 2020

nginx -s reload would be ideal, to make sure nginx falls back if the new configuration fails.

But for any of this to work the nginx binary will need to be mounted into the container.

@schenkd schenkd self-assigned this Jun 25, 2020
@schenkd schenkd added the enhancement New feature or request label Jun 25, 2020
@schenkd
Copy link
Owner

schenkd commented Jun 25, 2020

Hello @LucaNerlich, thank you very much for your issue. You're right, of course. The feature is important and will come. The goal for the next release is to manage multiple nginx instances. Since there are environments where nginx is running on both bare-metal and docker, I am looking for a good solution to cover both. I imagine that when integrating an nginx instance into nginx ui the type of the instance is specified (baremetal/docker).

@LucaNerlich
Copy link
Contributor Author

To execute a command on non-dockerized nginx from inside a docker container is going to be tricky / hacky. Im unsure myself, on how a good solution would look like.

@schenkd
Copy link
Owner

schenkd commented Jun 25, 2020

To execute a command on non-dockerized nginx from inside a docker container is going to be tricky / hacky. Im unsure myself, on how a good solution would look like.

My approach would be an SSH connection to the server with the necessary permissions to trigger a reload from nginx. The access data would then have to be stored in the form of a user management system. This would also allow the infrastructure to ensure that everyone is only allowed to do what the admin allows. :)

Best David

@LucaNerlich LucaNerlich changed the title Enhancement Request: Add "systemctl restart" button Enhancement Request: Add "systemctl restart nginx" button Jun 25, 2020
@rzabarazesh
Copy link

I've been pitching this tool at my workplace and this is the main feature stopping us from using it right now.

@mohamedtaee
Copy link

@LucaNerlich @rzabarazesh @TheFehr @kennyparsons I added a working button that restarts. Do any of you want to collaborate on my fork?
restartBtnFeature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Version 0.3
  
To do
Development

No branches or pull requests

6 participants