-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not process files more than once #342
Comments
michih57
added a commit
to michih57/scalastyle
that referenced
this issue
Feb 5, 2020
- see scalastyle#342 for the original bug - Directory.getFiles now filters out duplicates, returning unique files
Fixed and released here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello Scalastyle team!
I have a small, but annoying problem with Scalastyle and SBT plugin.
We use Play framework and what it does by default is setting
javaSource
andscalaSource
SBT variables to the same value${baseDirectory}/app
, which results inunmanagedSourceDirectories
and consequentlyscalastyleSources
having this value duplicated. This leads to each file in our Play projects being processed twice. Not only this take additional time, but also results in duplicate error/warning messages in the Scalastyle output.This can be fixed in multiple places: workaround in our projects, fix to scalastyle-sbt-plugin, and also here in Scalastyle itself. We can make
Directory.getFiles
method return only unique files (or add corresponding option).I can create the patch myself, just wanted to get your opinion on where this should be fixed.
The text was updated successfully, but these errors were encountered: