Compile then check style task #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 12, 2018 08:22
steinybot
changed the title
|
Going through and cleaning up all my old forks. Found this one covered in cobwebs. CI doesn't seem to be working... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a new
compileThenCheckStyletask which does what it sounds like it does. There is also ascalastyleCompileArgswhich is the input into thescalastyletask. Neither of these names are particularly great, if you come up with a better name I can change it.I didn't end up using
Def.sequentialas it only returns the result of the last task which would beUnitinstead ofAnalysis. The idea is the same though, useDef.taskDyn(which unfortunately means thatinspectdoesn't show it as a dependency).There are a few tests, some of which were added in a failing state so you can go back to those commits and make sure the tests are working correctly.
I'll submit another PR for the website later.
Closes #68