Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Scala 3 LSP tests for symbol search #6331

Open
tgodzik opened this issue Apr 19, 2024 · 1 comment
Open

Add more Scala 3 LSP tests for symbol search #6331

tgodzik opened this issue Apr 19, 2024 · 1 comment
Assignees
Labels
tech debt We should have addressed this yesterday

Comments

@tgodzik
Copy link
Contributor

tgodzik commented Apr 19, 2024

Describe the bug

We removed testing of nightly compiler in out cross tests, since that proved to be a big burden. We need to make sure that we at least have a few tests making sure that symbol search is used correctly by the Scala 3 presentation compiler.

We might want to do that for Scala LTS Next or just nightly?

This is already partly tested in CompletionCrossLspSuite

Expected behavior

More tests!

Operating system

Linux

Editor/Extension

VS Code

Version of Metals

v1.3.0

Extra context or search terms

tests

@tgodzik tgodzik added the tech debt We should have addressed this yesterday label Apr 19, 2024
@tgodzik tgodzik added this to Triage in Metals Issue Board via automation Apr 19, 2024
@tgodzik tgodzik self-assigned this Apr 19, 2024
@tgodzik tgodzik moved this from Triage to To do in Metals Issue Board Apr 19, 2024
@rochala
Copy link
Collaborator

rochala commented Apr 19, 2024

Afaik we will have nightly for both LTS line and next. We should test for both if test suite is fast enough. If this is the case it should be run on every PR, which will ensure that Symbol Search is still working on both sides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt We should have addressed this yesterday
Projects
Status: To do
Development

No branches or pull requests

2 participants