Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stripPrefix("-J") workaround for Metals #1456

Open
tgodzik opened this issue Feb 9, 2021 · 0 comments · May be fixed by #2192
Open

Remove stripPrefix("-J") workaround for Metals #1456

tgodzik opened this issue Feb 9, 2021 · 0 comments · May be fixed by #2192
Labels
on hold sanity

Comments

@tgodzik
Copy link
Contributor

tgodzik commented Feb 9, 2021

In order not to leak internal Bloop implementation we decided to no longer user -J when running via DAP. This is no longer needed since we have a separate field for jvm options. For a smooth transition however, we decided to add a workaround that will strip -J prefix when it's passed from Metals.

We should be good to remove it once Metals is release with 1.4.7 version of Bloop.

PR that introduces this: https://github.com/scalacenter/bloop/pull/1455/files
@tgodzik tgodzik mentioned this issue Feb 9, 2021
Merged
adpi2 added a commit to adpi2/metals that referenced this issue Feb 17, 2021
@adpi2
Upgrade to Bloop 1.4.7 + remove -J prefix
f860f0e 
As of scalacenter/bloop#1455 Bloop do not need
the -J prefix on the jvmOptions. Also there is a plan to remove support
for the -J prefix coming from debugSession/start request
(scalacenter/bloop#1456).
@adpi2 adpi2 mentioned this issue Feb 17, 2021
Merged
tgodzik pushed a commit to scalameta/metals that referenced this issue Feb 17, 2021
@adpi2 @tgodzik
Upgrade to Bloop 1.4.7 + remove -J prefix
1d3f4f1 
As of scalacenter/bloop#1455 Bloop do not need
the -J prefix on the jvmOptions. Also there is a plan to remove support
for the -J prefix coming from debugSession/start request
(scalacenter/bloop#1456).
@adpi2 adpi2 linked a pull request Nov 16, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
on hold sanity
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Log debuggee command adpi2/bloop
1 participant
@tgodzik