Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request more control over input/output pixel formats (BGRA32 / PBGRA32) #90

Open
rickbrew opened this issue Jul 20, 2022 · 1 comment
Open

Comments

@rickbrew
Copy link
Contributor

I have two specific needs when using MagicScaler that, from our discussions on Discord, are not quite satisfied:

  • The ability to provide a BGRA32 input and get the output as PBGRA32
    • In this case, MagicScaler is doing its computations in premultiplied and then unpremultiplies at the end. And then I need to premultiply again. This would reduce CPU usage.
  • The ability to provide a PBGRA32 input and get the output as PBGRA32
    • As per our discussion, MagicScaler normalizes the output to BGRA32, which means I have to premultiply and use more CPU time.
@rickbrew
Copy link
Contributor Author

rickbrew commented Apr 3, 2023

Like we discussed on Discord, it would also be really useful if [P]BGRA128F were supported end-to-end. Other pixel formats are optimization gravy. This would allow me to normalize on [P]BGRA128F -- especially for my own implementations of scalers or other kernels -- and to just use converters for other pixel formats when necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants